[Webkit-unassigned] [Bug 40847] [GTK] Fix DOM event dispatch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40847





--- Comment #5 from Xan Lopez <xan.lopez at gmail.com>  2010-06-18 13:07:39 PST ---
(In reply to comment #4)
> Looks good to me!
> 
> Only one suggestion: Perhaps move the coreObject->ref() into the GObject itself. Since the object is responsible for the deref(), it makes sense for it to do the ref() as well.

Yeah, I actually planned to do this, but the issue is you cannot know the type of the coreObject in WebKitDOMObject, where that code lives, so you cannot do the casting we do in the wrap method to call ->ref(). On the other hand I don't think that's really needed, I suppose if you cast it to some really low level class where ref/deref are defined it should be more than enough.

> 
> You've exposed addEventListener to the bindings (I think). Is that part of some later work, or required for this patch?

I actually didn't, they are blacklisted in CodeGeneratorGObject. I just removed the guards that were there so that the Node wrapper correctly adds its event listeners.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.