[Webkit-unassigned] [Bug 40847] [GTK] Fix DOM event dispatch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 18 11:48:15 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40847


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mrobinson at webkit.org




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2010-06-18 11:48:15 PST ---
Looks good to me!

Only one suggestion: Perhaps move the coreObject->ref() into the GObject itself. Since the object is responsible for the deref(), it makes sense for it to do the ref() as well.

You've exposed addEventListener to the bindings (I think). Is that part of some later work, or required for this patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list