[Webkit-unassigned] [Bug 40807] [EFL] add support for logging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40807





--- Comment #5 from Gustavo Sverzut Barbieri <barbieri at profusion.mobi>  2010-06-18 10:23:58 PST ---
Hi Joone Hur,

Thanks for your patch, but it is not the way to go. EFL provides Eina Logging, and we should use it as it is appropriate. We must register all the known WTFLogChannel (WebCore/platform/Logging.h) as eina log domains with the eina_log primitives being used in JavaScriptCore/wtf/Assertions.h and JavaScriptCore/wtf/Assertions.cpp as done for Symbian, Mac, Windows and others. From a quick look Eina is fully capable of providing the requirements, if not just let me know and I'll extend eina to provide it, or explain another solution.

Your point about "it's webkit and not ewk" log is not fine, as it should behave as a single component, and replicating environment variables will not help. With a very minor effort in the above mentioned files we can make it fully integrated and consistent.

I hope you understand our point.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.