[Webkit-unassigned] [Bug 40807] [EFL] add support for logging

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40807





--- Comment #4 from Joone Hur <joone at kldp.org>  2010-06-18 09:54:30 PST ---
(In reply to comment #3)
> (In reply to comment #0)
> > Logging is not fully implemented for EFL port.
> > 
> > WebKit/WebCore/platform/efl/LoggingEfl.cpp
> > 
> > 
> > namespace WebCore {
> > 
> > void InitializeLoggingChannelsIfNecessary()
> > {
> >     LogNotYetImplemented.state = WTFLogChannelOn;
> > }
> > 
> > }
> 
> Ohh.. Re-thinking about this and the function's name ("IfNecessary"): it's not needed at all because eina_log was already initialized in ewk_main(). With this patch you are justing creating another environment variable to re-implement what is done in eina_log. You should just use
> 
> EINA_LOG_LEVELS=<your_log_channel_1>:<your_log_level_1>
> 
> Using this environment variable, each log channel is separated by "," like in:
> 
> EINA_LOG_LEVELS=ewebkit:2,ewebkit-demo:5 ewebkit-demo

This logging feature is used for printing log information of WebCore.
It is not relevant to ewk stuff.

Regarding "," separator, GTK port uses " " separator. 
It seems no problem because all log channel names of WebCore don't have space

About the comment rule you guided, I will follow it.

Thanks for the review :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.