[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 16 21:53:09 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=27551


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit.review.bot at gmail.com




--- Comment #30 from WebKit Review Bot <webkit.review.bot at gmail.com>  2010-06-16 21:53:08 PST ---
Attachment 58961 did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Last 3072 characters of output:
150:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/runtime/JSCell.h:77:  Use 0 instead of NULL.  [readability/null] [4]
JavaScriptCore/runtime/JSCell.h:78:  Use 0 instead of NULL.  [readability/null] [4]
JavaScriptCore/wtf/text/WTFString.h:89:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/WTFString.h:109:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/WTFString.h:110:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/WTFString.h:213:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/WTFString.h:295:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/WTFString.h:302:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/WTFString.h:303:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/WTFString.h:303:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/text/WTFString.h:303:  More than one command on the same line in if  [whitespace/parens] [4]
JavaScriptCore/wtf/unicode/Collator.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
JavaScriptCore/wtf/CurrentTime.h:42:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
JavaScriptCore/wtf/RandomNumber.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
JavaScriptCore/wtf/FastMalloc.h:32:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
JavaScriptCore/wtf/text/AtomicString.h:46:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/AtomicString.h:47:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/AtomicString.h:60:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/AtomicString.h:117:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/wtf/text/AtomicString.h:117:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/text/AtomicString.h:117:  More than one command on the same line in if  [whitespace/parens] [4]
JavaScriptCore/wtf/text/CString.h:61:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
JavaScriptCore/runtime/InitializeThreading.h:36:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
JavaScriptCore/wtf/RefCountedLeakCounter.h:29:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 25 in 72 files


If any of these errors are false positives, please file a bug against check-webkit-style.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list