[Webkit-unassigned] [Bug 27551] Make it possible to build JavaScriptCore as shared library without symbol lists

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 16 21:51:33 PDT 2010


Kevin Ollivier <kevino at theolliviers.com> changed:

           What    |Removed                     |Added
  Attachment #34832|0                           |1
        is obsolete|                            |
  Attachment #58961|                            |review?
               Flag|                            |

--- Comment #29 from Kevin Ollivier <kevino at theolliviers.com>  2010-06-16 21:51:32 PST ---
Created an attachment (id=58961)
 --> (https://bugs.webkit.org/attachment.cgi?id=58961)
Use JS_EXPORT_PRIVATE to export individual symbols

I built wx with this successfully but I wasn't able to build the Win port because I'm using 2008 and it appears the build scripts for Win don't support that yet. So probably a good idea to let the bots chew on this patch first. 

Overall, it's a very big patch but almost all of it is just adding JS_EXPORT_PRIVATE to various symbols. I also include the wx build changes, though they weren't much. The main thing to look at for review is the config.h file changes, and for a couple of the classes like String and AtomicString, I had to add explicit copy constructors and operator= methods so that I could specify the correct linkage for them. Other than that, I pretty much just prepended JS_EXPORT_PRIVATE to everything that some other library was asking for.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list