[Webkit-unassigned] [Bug 40327] Leftover calls to RenderStyle color accessors, which are no longer public methods.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40327





--- Comment #17 from Alex Milowski <alex at milowski.com>  2010-06-16 09:47:44 PST ---
(In reply to comment #16)
> (In reply to comment #15)
> > The previous reviewer denied the review because I documented that in the change log.
> 
> I just read David’s comments; he suggested that the comment from the change log go into a comment in the the source file instead. You disagreed and instead deleted the explanation entirely. That was a mistake.
> 
> If you strongly felt a comment should not go in the source file, then you should have left it in the change log.
> 
> Checking in a change with no explanation at all is wrong. You can check with him, but I’m sure David and I both agree on that.

I'm just trying to push this all along.  I deleted the comment from the change log against my better judgement trying to see if I can get my code changes in so this will compile again.

My general experience is that reviewer are very inconsistent in terms of what they expect.  So, next I'll submit a patch that you like and someone else will review it and they'll deny it on the basis of the changes you expect.  ...and then the cycle starts again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.