[Webkit-unassigned] [Bug 40327] Leftover calls to RenderStyle color accessors, which are no longer public methods.

Wed Jun 16 09:26:26 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=40327

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |darin at apple.com

--- Comment #16 from Darin Adler <darin at apple.com>  2010-06-16 09:26:26 PST ---
(In reply to comment #15)
> The previous reviewer denied the review because I documented that in the change log.

I just read David’s comments; he suggested that the comment from the change log go into a comment in the the source file instead. You disagreed and instead deleted the explanation entirely. That was a mistake.

If you strongly felt a comment should not go in the source file, then you should have left it in the change log.

Checking in a change with no explanation at all is wrong. You can check with him, but I’m sure David and I both agree on that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.