[Webkit-unassigned] [Bug 40352] [Qt] instance objects created for QObjects are somtimes GC'd

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40352





--- Comment #6 from Sam Magnuson <smagnuson at netflix.com>  2010-06-15 09:15:28 PST ---
(In reply to comment #5)
> (From update of attachment 58554 [details])
> The patch doesn't apply cq-
> There are a few unrelated changes and coding style issues (r-)
> there are no autotest.
> 
> You can use check-webkit-style script to check some coding style issues.
> 

I did run check-webkit-style and when I fixed the issues flagged there, you r- it with unrelated changes. Is it the group preference that the old things that didn't pass check-webkit-style get left alone, and I have to ferret out the lines that I change from the output of check-webkit-style? That seems like more work than just fixing the coding style issues.

> > +        No new tests. (OOPS!)
> Please provide autotest.
> 

I'm not sure how to autotest this, it is related to a gc issue and not marking children. Can you point me to a test that is related that I can review?

> >  #include "ArgList.h"
> > +#include "Error.h"
> >  #include "JSDOMBinding.h"
> >  #include "JSGlobalObject.h"
> >  #include "JSLock.h"
> > +#include "ObjectPrototype.h"
> > +#include "PropertyNameArray.h"
> >  #include "qt_class.h"
> >  #include "qt_runtime.h"
> > -#include "PropertyNameArray.h"
> >  #include "runtime_object.h"
> > -#include "ObjectPrototype.h"
> > -#include "Error.h"
> 
> > -    foreach(QtInstance* instance, cachedInstances.values(o))
> > +    foreach (QtInstance* instance, cachedInstances.values(o))
> These changes are unrelated (there are more). Please cleanup the patch.
> 

I was fixing what check-webkit-style had flagged - I got the impression it was to pass that script with no errors.

> > +#if 1
> > +#endif
> This should be avoided.
> 

Agree, will remove.

> > +        } else if ( m_object ) {
> A coding style issue.

Can you be more specific? check-webkit-style doesn't flag any issues on the file as it is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.