[Webkit-unassigned] [Bug 40352] [Qt] instance objects created for QObjects are somtimes GC'd

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40352


Jędrzej Nowacki <jedrzej.nowacki at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58554|review?                     |review-, commit-queue-
               Flag|                            |




--- Comment #5 from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>  2010-06-15 05:33:57 PST ---
(From update of attachment 58554)
The patch doesn't apply cq-
There are a few unrelated changes and coding style issues (r-)
there are no autotest.

You can use check-webkit-style script to check some coding style issues.

> +        No new tests. (OOPS!)
Please provide autotest.

>  #include "ArgList.h"
> +#include "Error.h"
>  #include "JSDOMBinding.h"
>  #include "JSGlobalObject.h"
>  #include "JSLock.h"
> +#include "ObjectPrototype.h"
> +#include "PropertyNameArray.h"
>  #include "qt_class.h"
>  #include "qt_runtime.h"
> -#include "PropertyNameArray.h"
>  #include "runtime_object.h"
> -#include "ObjectPrototype.h"
> -#include "Error.h"

> -    foreach(QtInstance* instance, cachedInstances.values(o))
> +    foreach (QtInstance* instance, cachedInstances.values(o))
These changes are unrelated (there are more). Please cleanup the patch.

> +#if 1
> +#endif
This should be avoided.

> +        } else if ( m_object ) {
A coding style issue.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.