[Webkit-unassigned] [Bug 40261] [Qt] SmartReplaceQt.cpp has coding-style errors

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40261


Jędrzej Nowacki <jedrzej.nowacki at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|Other                       |All
         OS/Version|Mac OS X 10.5               |All
             Status|UNCONFIRMED                 |NEW
           Keywords|                            |QtTriaged
           Severity|Normal                      |Trivial
           Priority|P2                          |P5
                 CC|                            |jedrzej.nowacki at nokia.com
     Ever Confirmed|0                           |1




--- Comment #3 from Jędrzej Nowacki <jedrzej.nowacki at nokia.com>  2010-06-15 04:37:42 PST ---
I don't like it, it destroys history of changes. I think it is not in the we work with webkit, general policy is that code shouldn't be changed only for a style reason.

Personally I preferred previous version, but you are right, it is not webkit style. If you do want to make a fix, please change comments, they should be full phrases with point at the end.

(In reply to comment #2)
> (From update of attachment 58079 [details])
> >+ No new tests. (OOPS!)
> :(
The change don't need tests.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.