[Webkit-unassigned] [Bug 40608] [chromium]Refactor input method related APIs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40608





--- Comment #9 from Tony Chang (Google) <tony at chromium.org>  2010-06-15 00:36:46 PST ---
(From update of attachment 58757)
WebCore/page/FocusController.cpp:600
 +      // session.
FWIW, this sounds like a functional change, even though the ChangeLog says this isn't a functional change.

WebKit/chromium/src/WebViewImpl.h:100
 +      virtual bool setComposition(
Should this return more than just a bool?  For example, I think the cancel composition work would be easier if this returned an enum (COMPOSITION_SET, COMPOSITION_CANCELED, or KEYPRESS_CANCELED) or something.  A bool is probably fine if there's a way to query what the current composition text is (e.g., if a keydown is prevented, setComposition can return false and the render view can query the webview to see what the current composition text should be set to in the browser process).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.