[Webkit-unassigned] [Bug 36903] Implement BlobBuilder internal class for BlobBuilder support as defined in FileWriter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36903





--- Comment #13 from Kinuko Yasuda <kinuko at chromium.org>  2010-06-10 15:10:06 PST ---
(In reply to comment #11)
> (From update of attachment 58260 [details])
> WebCore/html/Blob.h:74
>  +      Blob(const String& type, const BlobItemList& items);
> 'items' can be omitted.

Done.

> WebCore/html/Blob.cpp:94
>  +      return Blob::create(contentType, items);
> // FIXME: Pass content type when we add it to slice's arguments.
> return Blob::create(String(), items);

Done.  Accordingly changed the Blob::create's first param const String& -> const String (its implementation is just a RefPtr).

> WebCore/html/BlobBuilder.cpp:39
>  +  #include "StringHash.h"
>  +  #include <wtf/HashMap.h>

Removed both includes.

> WebCore/html/BlobBuilder.cpp:81
>  +      if (!blob)
> Probably it is simpler to say:
>     if (blob)
>         for (...)
>             ...
>     return true;

Fixed.

> WebCore/html/BlobBuilder.h:37
>  +  #include "ExceptionCode.h"
> Including ExceptionCode.h is not needed.

Fixed.

> WebCore/html/BlobBuilder.h:51
>  +      bool appendString(const WebCore::String& text, const WebCore::String& ending, ExceptionCode& ec);
> The namespace WebCore is not necessary.

Fixed.

>  +      PassRefPtr<Blob> getBlob(const WebCore::String& contentType) const;
> ditto.

Fixed.

> WebCore/platform/BlobItem.cpp:135
>  +  #else
> How about CR in mac?

Is older Mac supported by WebKit?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.