[Webkit-unassigned] [Bug 36903] Implement BlobBuilder internal class for BlobBuilder support as defined in FileWriter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36903


Jian Li <jianli at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #58416|review?                     |review-
               Flag|                            |




--- Comment #14 from Jian Li <jianli at chromium.org>  2010-06-11 15:56:28 PST ---
(From update of attachment 58416)
Some more comments.

WebCore/html/Blob.h:44
 +      static PassRefPtr<Blob> create(const String type, const BlobItemList& items)
"const String" in create() is inconsistent with "const String&" in Blob().

WebCore/html/Blob.h:73
 +      Blob() { }
Is this needed?

WebCore/html/BlobBuilder.h:40
 +  #include <wtf/Vector.h>
This seems not to be needed.

WebCore/html/BlobBuilder.h:57
 +      BlobBuilder();
We do not really need this default constructor.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.