[Webkit-unassigned] [Bug 40327] Leftover calls to RenderStyle color accessors, which are no longer public methods.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40327





--- Comment #1 from Clemmitt Sigler <cmsigler at gmail.com>  2010-06-09 05:28:50 PST ---
(In reply to comment #0)
<snip>
> made invalid by Rev. 59956.  That rev. made RenderStyle color
> accessors private, but there are still a goodly number of calls,
> e.g. 'style()->color()', that lurk in a number of modules in the
> tree, including RenderMathMLRoot.cpp and RenderMathMLSquareRoot.cpp.
<snip>
> Do all modules having 'style()->color()' calls simply need to declare
> themselves friends of RenderStyle?  Is that simple solution really
> the correct solution???

OK, I have more of my wits about me this morning.  If all existing 'style()->color()' calls are the only instances of offending out-of-date code, then this problem exists only in these three modules in the tree:

WebKit/WebCore/rendering/RenderTreeAsText.cpp
WebKit/WebCore/mathml/RenderMathMLRoot.cpp
WebKit/WebCore/mathml/RenderMathMLSquareRoot.cpp

I note that RenderTreeAsText.cpp isn't generating errors because WebCore/rendering/style/RenderStyle.h declares 'friend class RenderTreeAsText', so I'll try exactly the same solution:

friend class RenderMathMLRoot
friend class RenderMathMLSquareRoot

in RenderStyle.h with corresponding FIXME comments like Dave Hyatt did in rev. 59956.

Patch coming RSN.  HTH.

Clemmitt

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.