[Webkit-unassigned] [Bug 40327] New: Leftover calls to RenderStyle color accessors, which are no longer public methods.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40327

           Summary: Leftover calls to RenderStyle color accessors, which
                    are no longer public methods.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: cmsigler at gmail.com


Hi,

I just filed Bug 40326, which causes WebCore/mathml/RenderMathMLRoot.cpp and WebCore/mathml/RenderMathMLSquareRoot.cpp to be re-included in the WebKitGtk build process for GtkLauncher.  This change has uncovered some stale code that was made invalid by Rev. 59956.  That rev. made RenderStyle color accessors private, but there are still a goodly number of calls, e.g. 'style()->color()', that lurk in a number of modules in the tree, including RenderMathMLRoot.cpp and RenderMathMLSquareRoot.cpp.

All this stale code needs to be searched out and updated.  I don't believe I can make this contribution myself; I don't know the correct method to update the code :^(

Rev. 59956 is documented thusly:

"Make the RenderStyle color accessors private. This forces callers to use visitedDependentColor
instead (or to make the decision to become friends of the RenderStyle class in order to get access
to the real style information)."

Do all modules having 'style()->color()' calls simply need to declare themselves friends of RenderStyle?  Is that simple solution really the correct solution???

Sorry I can't be of more help.

Clemmitt

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.