[Webkit-unassigned] [Bug 40301] DOM storage should only create databases when needed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40301





--- Comment #6 from hans at chromium.org  2010-06-09 04:17:44 PST ---
(In reply to comment #5)
> (From update of attachment 58154 [details])
> WebCore/storage/StorageAreaSync.cpp:66
>  +      , m_triedOpeningDatabase(false)
> How about m_databaseOpenFailed
Done.

> WebCore/storage/StorageAreaSync.cpp:206
>  +      ASSERT(!m_database.isOpen());
> Assert we haven't tried yet.
Done.

> WebCore/storage/StorageAreaSync.h:79
>  +            CreateDatabase,
> These names are not very clear.  The point is that creation is allowed, but this sounds like you're saying always create it.
Done. Trying new names.

> WebCore/storage/StorageAreaSync.cpp:307
>  +      if (!m_database.isOpen() && !m_triedOpeningDatabase)
> If you change the name as I suggested, then you can simply do "if m_databaseOpenFailed return;" before this statement.  I think it's more clear.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.