[Webkit-unassigned] [Bug 40063] Web Inspector: make SourceFrame BreakpointManager's listener

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 4 06:25:17 PDT 2010


--- Comment #3 from Yury Semikhatsky <yurys at chromium.org>  2010-06-04 06:25:16 PST ---
(In reply to comment #2)
> (From update of attachment 57791 [details])
> WebCore/inspector/front-end/ScriptsPanel.js:279
>  +              if (script._scriptView) {
> Nit: encapsulate this into script.disposeView();
Script and Resource are not aware of there views (despite they have _sourceView and _scriptView fields) that is why I didn't add disposeView to them.

> WebCore/inspector/front-end/ScriptsPanel.js:448
>  +                      object._scriptView.willRemoveScript();
> Why is this needed?
To remove SourceFrame from BreakpointManager listeners list.

> WebCore/inspector/front-end/SourceFrame.js:198
>  +          if (!(breakpoint.sourceID in this._scriptIds)) {
> So you ended up with making SourceFrame both sourceID and sourceURL aware without external binding. It might be simple, not sure it is good design-wise though.
We need either them or a filter to detect breakpoints that should be displayed.

> WebCore/inspector/front-end/SourceView.js:129
>  +              this.sourceFrame.addBreakpointsForURL(resource.sourceURL);
> I thought the point was to make SourceFrame breakpoint manager's listener so that breakpoints are not populated from outside.
Adding listeners to BreakpointManager is not enough because we need to pull breakpoints that already exist when SourceFrame is being created. I'm open to alternative solutions.

> WebCore/inspector/front-end/SourceView.js:240
>  +              this.localSourceFrame = new WebInspector.SourceFrame(this.localContentElement, null, null, null, null);
> just pass single parameter.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list