[Webkit-unassigned] [Bug 40063] Web Inspector: make SourceFrame BreakpointManager's listener

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40063


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57791|review?                     |
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2010-06-03 11:45:12 PST ---
(From update of attachment 57791)
WebCore/inspector/front-end/ScriptsPanel.js:279
 +              if (script._scriptView) {
Nit: encapsulate this into script.disposeView();

WebCore/inspector/front-end/ScriptsPanel.js:448
 +                      object._scriptView.willRemoveScript();
Why is this needed?

WebCore/inspector/front-end/SourceFrame.js:198
 +          if (!(breakpoint.sourceID in this._scriptIds)) {
So you ended up with making SourceFrame both sourceID and sourceURL aware without external binding. It might be simple, not sure it is good design-wise though.

WebCore/inspector/front-end/SourceView.js:129
 +              this.sourceFrame.addBreakpointsForURL(resource.sourceURL);
I thought the point was to make SourceFrame breakpoint manager's listener so that breakpoints are not populated from outside.

WebCore/inspector/front-end/SourceView.js:240
 +              this.localSourceFrame = new WebInspector.SourceFrame(this.localContentElement, null, null, null, null);
just pass single parameter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.