[Webkit-unassigned] [Bug 39958] [Qt] TextBreakIteratorQt performance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39958





--- Comment #14 from Simon Hausmann <hausmann at webkit.org>  2010-06-02 03:45:05 PST ---
(In reply to comment #13)
> Created an attachment (id=57586)
 --> (https://bugs.webkit.org/attachment.cgi?id=57586) [details]
> Patch, lets try this again.
> 
> Thanks for the review again Kenneth, Simon :)
> 
> Updated the patch to use StringImpl's hash as a key to the cached TextBreakIterator. The hash is calculated only once as needed and can be used to identify the string. If the hash and search type is the same, then we re-used the iterator. 
> 
> There is no dependency on the string pointer anymore, so it should not crash in the case the string pointer is ever reused with a string that has the same length but different content.

That's a great idea!

How can we protect ourselves from hash collisions?

> I overloaded the TextBreakIterator functions instead of changing all of them, I am worried it may break other port's builds.

The EWS can help us with that :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.