[Webkit-unassigned] [Bug 39958] [Qt] TextBreakIteratorQt performance

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 13:12:01 PDT 2010


David Leong <david.leong at nokia.com> changed:

           What    |Removed                     |Added
  Attachment #57586|                            |review?
               Flag|                            |

--- Comment #13 from David Leong <david.leong at nokia.com>  2010-06-01 13:12:00 PST ---
Created an attachment (id=57586)
 --> (https://bugs.webkit.org/attachment.cgi?id=57586)
Patch, lets try this again.

Thanks for the review again Kenneth, Simon :)

Updated the patch to use StringImpl's hash as a key to the cached TextBreakIterator. The hash is calculated only once as needed and can be used to identify the string. If the hash and search type is the same, then we re-used the iterator. 

There is no dependency on the string pointer anymore, so it should not crash in the case the string pointer is ever reused with a string that has the same length but different content.

I overloaded the TextBreakIterator functions instead of changing all of them, I am worried it may break other port's builds.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list