[Webkit-unassigned] [Bug 40003] [Qt] Fix the lifecycle of notification objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40003





--- Comment #8 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-01 18:25:04 PST ---
(In reply to comment #5)
> Created an attachment (id=57587)
 --> (https://bugs.webkit.org/attachment.cgi?id=57587) [details]
> Patch.
> 
> Rename addPage/removePage/m_pageCount to addClient/removeClient/m_clientCount and make the timeout a static global.
> 
> I did not define the notification presenter with DEFINE_STATIC_LOCAL, because I could not find a way to delete it if I made it a static in a local function. Please advice if there is a way to do that.

DEFINE_STATIC_LOCAL is for when you do not intent deleting it, ever :-) it makes sure that when you exit the application it will leak. Why? Because the OS is quicker at cleaning up then C++ :-)

Please disregard my original comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.