[Webkit-unassigned] [Bug 40003] [Qt] Fix the lifecycle of notification objects

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 1 18:23:18 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=40003


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kenneth at webkit.org




--- Comment #7 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2010-06-01 18:23:17 PST ---
(In reply to comment #4)
> (In reply to comment #2)
> > (From update of attachment 57554 [details] [details])
> > WebKit/qt/WebCoreSupport/NotificationPresenterClientQt.cpp:57
> >  +      s_notificationPresenter = new NotificationPresenterClientQt();
> > So we always leak this one? (im not finished reading the patch), maybe we should use STATIC_LOCAL
> 
> Maybe I am missing something, but if I use DEFINE_STATIC_LOCAL, I don't see how to get access to the static variable in order to delete it in the end.

I should have removed that comment. I did it before I had seen all of the patch, sorry.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list