[Webkit-unassigned] [Bug 36359] Double clicking page's last editable inline element doesn't select a word.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36359


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57292|review?                     |review-
               Flag|                            |




--- Comment #28 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-30 23:15:28 PST ---
(From update of attachment 57292)
LayoutTests/editing/selection/doubleclick-inline-first-last-contenteditable-expected.txt:1
 +  here to double click, and there
Very confusing output.
Can you use the js-test-pre.js / js-test-post.js framework, and create a better test case?

That would also avoid having to write your custom log() function.
WebCore/editing/TextIterator.cpp:275
 +      // FIXME: should support TextIteratorEndsAtEditingBoundary
You should file a bug for that, and refer to it here.

WebCore/editing/TextIterator.cpp:950
 +      : m_behavior(TextIteratorDefaultBehavior), m_node(0), m_positionNode(0)
Each initialization belongs in its own line.

WebCore/editing/TextIterator.cpp:955
 +      : m_behavior(behavior), m_node(0), m_positionNode(0)
Ditto.

WebCore/editing/TextIterator.h:187
 +      bool crossesEditingBoundary(Node* node) const;
You can omit the "node" name here.

WebCore/editing/TextIterator.h:188
 +      bool setCurrentNode(Node* node);
Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.