[Webkit-unassigned] [Bug 39204] schedule/unscheduleAll API in ResourceHandleMac

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=39204


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56220|review?                     |review-
               Flag|                            |




--- Comment #7 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-30 23:01:30 PST ---
(From update of attachment 56220)
r-, because of the layering violation.

I have no clue about this particular part of the code, but you could avoid passing Page, by just querying Page* from the call site, and pass in a SchedulePairHashSet* pointer to your scheduleAll/unscheduleAll functions.
Not sure if this design is good at all, other reviewers could comment better than me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.