[Webkit-unassigned] [Bug 40627] Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 29 15:49:47 PDT 2010


--- Comment #35 from Joseph Pecoraro <joepeck at webkit.org>  2010-07-29 15:49:47 PST ---
> WebCore/loader/appcache/ApplicationCacheStorage.h:87
>  +      static const int64_t unknown = -1;
> I think this should be called "unknownQuota" to make it more descriptive.

Sounds good.

> WebCore/loader/appcache/ApplicationCacheStorage.cpp:426
>  +      // Using the count to determine if a record existed or not is a safe way to determine=
> Not sure if it's a mail encoding issue, but there is a stray "=" at the end of "determine" here.

My fault, a typo. I'll fix.

> WebCore/loader/appcache/ApplicationCacheStorage.cpp:461
>  +                  " WHERE Origins.origin=?"
> Please put spaces around the "=" operator (unless this is the prevailing style for bound values in this file).

No space is the prevailing style:


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list