[Webkit-unassigned] [Bug 40627] Limit ApplicationCache Total and Per-Origin Storage Capacity (Quotas)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=40627


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #59692|review?                     |review+
               Flag|                            |




--- Comment #34 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-07-29 15:43:01 PST ---
(From update of attachment 59692)
WebCore/loader/appcache/ApplicationCacheStorage.h:87
 +      static const int64_t unknown = -1;

I think this should be called "unknownQuota" to make it more descriptive.


WebCore/loader/appcache/ApplicationCacheStorage.cpp:426
 +      // Using the count to determine if a record existed or not is a safe way to determine=

Not sure if it's a mail encoding issue, but there is a stray "=" at the end of "determine" here.


WebCore/loader/appcache/ApplicationCacheStorage.cpp:461
 +                  " WHERE Origins.origin=?"

Please put spaces around the "=" operator (unless this is the prevailing style for bound values in this file).

WebCore/loader/appcache/ApplicationCacheStorage.cpp:462
 +                  "   AND Caches.id!=?";

Ditto.

WebCore/loader/appcache/ApplicationCacheStorage.cpp:468
 +                  " WHERE Origins.origin=?";

Ditto.


WebCore/loader/appcache/ApplicationCacheStorage.cpp:501
 +      SQLiteStatement updateStatement(m_database, "UPDATE Origins SET quota=? WHERE origin=?");

Ditto.

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.