[Webkit-unassigned] [Bug 43134] Add idl and mock implementation for HTML5 FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43134





--- Comment #7 from Kinuko Yasuda <kinuko at chromium.org>  2010-07-29 15:47:54 PST ---
Thanks for reviewing.

(In reply to comment #6)
> (From update of attachment 62914 [details])
> r=me, but please address the comments below, and make sure you can build webkit and chromium before you submit the patch.
> 
> WebCore/bindings/scripts/CodeGenerator.pm:348
>  +      $ret =~ s/^CREATE/Create/ if $ret =~ /^CREATE$/;
> now that i look at this code, i think we can do a little better: instead of adding special cases for CREATE and EXCLUSIVE, we can do the same trick for all uppercase strings.
> basically, i think we should just add 'return ucfirst(lc($param)) if $param eq uc($param);' at the beginning of this function.

Yeah it'll be cleaner - I didn't do so out of fear to break something, but it looks ok as you say (grepping confirmed that).
I'll change like that.  I'll also fix bool in idl and make sure they can be built on both platforms before submitting.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.