[Webkit-unassigned] [Bug 43134] Add idl and mock implementation for HTML5 FileSystem API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43134


Dumitru Daniliuc <dumi at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62914|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #6 from Dumitru Daniliuc <dumi at chromium.org>  2010-07-29 01:36:32 PST ---
(From update of attachment 62914)
r=me, but please address the comments below, and make sure you can build webkit and chromium before you submit the patch.

WebCore/bindings/scripts/CodeGenerator.pm:348
 +      $ret =~ s/^CREATE/Create/ if $ret =~ /^CREATE$/;
now that i look at this code, i think we can do a little better: instead of adding special cases for CREATE and EXCLUSIVE, we can do the same trick for all uppercase strings.

basically, i think we should just add 'return ucfirst(lc($param)) if $param eq uc($param);' at the beginning of this function.

sorry i didn't think about this earlier.

WebCore/bindings/scripts/CodeGenerator.pm:367
 +      $ret =~ s/^cREATE/isCreate/ if $ret =~ /^cREATE$/;
same thing here, i think it's ok to assume for now that all uppercase attributes are boolean: return "is" . ucfirst(lc($param)) if $param eq uc($param);

WebCore/bindings/scripts/test/TestObj.idl:48
 +          attribute bool                     CREATE;
s/bool/boolean/. otherwise, we'll get lots of non-sense includes like "JSbool.h" and "V8bool.h".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.