[Webkit-unassigned] [Bug 43204] Add symbol export macros to C++ DOM bindings

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43204





--- Comment #3 from Kevin Ollivier <kevino at theolliviers.com>  2010-07-29 15:24:20 PST ---
(In reply to comment #2)
> (From update of attachment 62976 [details])
> In general this looks fine, but I think you should better align the macros with the versions in JavaScriptCore/API/JSBase.h.
> See JS_EXPORT as example, maybe add a comment to both files that the logic should stay in sync. The declspec(dllimport) vs. dllexport logic looks reversed compared to JSBase.h, is this intentional?

I think I actually followed the macros in JavaScriptCore/config.h as a base since we use default symbol visibility on GCC and thus only needed Windows support. I added the GCC code later since I figured we should handle the case where people have hidden symbols by default on GCC. Changing the order, of course, is no problem (and avoids a extra check on defined(GCC)), and I'll go ahead and add the note too.

> You should also grep if there are any other variations of these or similar macros throughout WebKit (WebCore/JavaScriptCore/WebKit).

Yeah, actually, I probably know about every place in the code that such defines exist at this point, as I've had to delve into this quite a bit while working on #27551. :)

After getting #27551 taken care of, what I'd actually like to do is come up with something like SYMBOL_EXPORT, defined using the JSBase.h logic, and have projects define WHATEVER_EXPORT to SYMBOL_EXPORT based whenever a symbol should be exported. The big question is where to define SYMBOL_EXPORT, though, in a way that it's pretty much universally available.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.