[Webkit-unassigned] [Bug 43204] Add symbol export macros to C++ DOM bindings

Thu Jul 29 14:02:19 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43204

Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62976|review?                     |review-
               Flag|                            |

--- Comment #2 from Nikolas Zimmermann <zimmermann at kde.org>  2010-07-29 14:02:19 PST ---
(From update of attachment 62976)
In general this looks fine, but I think you should better align the macros with the versions in JavaScriptCore/API/JSBase.h.
See JS_EXPORT as example, maybe add a comment to both files that the logic should stay in sync. The declspec(dllimport) vs. dllexport logic looks reversed compared to JSBase.h, is this intentional?

You should also grep if there are any other variations of these or similar macros throughout WebKit (WebCore/JavaScriptCore/WebKit).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.