[Webkit-unassigned] [Bug 43163] Add a CF-style base type (WKTypeRef) as a base for polymorphic functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43163





--- Comment #4 from Sam Weinig <sam at webkit.org>  2010-07-28 18:00:06 PST ---
(In reply to comment #3)
> (From update of attachment 62900 [details])
> > +    virtual Type type() const { return TypeArray; }
> 
> > +    virtual Type type() const { return TypeString; }
> 
> > +    virtual Type type() const { return TypeURL; }
> 
> > +    virtual Type type() const { return TypeBackForwardList; }
> 
> > +    virtual Type type() const { return TypeBackForwardListItem; }
> 
> > +    virtual Type type() const { return TypeContext; }
> 
> > +    virtual Type type() const { return TypeFramePolicyListener; }
> 
> > +    virtual Type type() const { return TypeFrame; }
> 
> > +    virtual Type type() const { return TypeNavigationData; }
> 
> > +    virtual Type type() const { return TypePageNamespace; }
> 
> > +    virtual Type type() const { return TypePage; }
> 
> > +    virtual Type type() const { return TypePreferences; }
> 
> > +    virtual Type type() const { return TypeBundleFrame; }
> 
> > +    virtual Type type() const { return TypeBundlePage; }
> 
> Making this private may catch some callers accidentally calling the virtual function on something already known to be a WebArray.

Will do.

> > +    operator APIType() { return reinterpret_cast<APIType>(m_impl.get()); }
> 
> Doesn't static_cast work for this? If not, why not?

/Volumes/Data/Users/weinig/Code/webkit/OpenSource/WebKit2/UIProcess/API/C/WKAPICast.h:91: error: invalid static_cast from type 'WebKit::WebString*' to type 'OpaqueWKStringRef*'

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.