[Webkit-unassigned] [Bug 43163] Add a CF-style base type (WKTypeRef) as a base for polymorphic functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43163


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62900|review?                     |review+
               Flag|                            |




--- Comment #3 from Darin Adler <darin at apple.com>  2010-07-28 17:47:26 PST ---
(From update of attachment 62900)
> +    virtual Type type() const { return TypeArray; }

> +    virtual Type type() const { return TypeString; }

> +    virtual Type type() const { return TypeURL; }

> +    virtual Type type() const { return TypeBackForwardList; }

> +    virtual Type type() const { return TypeBackForwardListItem; }

> +    virtual Type type() const { return TypeContext; }

> +    virtual Type type() const { return TypeFramePolicyListener; }

> +    virtual Type type() const { return TypeFrame; }

> +    virtual Type type() const { return TypeNavigationData; }

> +    virtual Type type() const { return TypePageNamespace; }

> +    virtual Type type() const { return TypePage; }

> +    virtual Type type() const { return TypePreferences; }

> +    virtual Type type() const { return TypeBundleFrame; }

> +    virtual Type type() const { return TypeBundlePage; }

Making this private may catch some callers accidentally calling the virtual function on something already known to be a WebArray.

> +    operator APIType() { return reinterpret_cast<APIType>(m_impl.get()); }

Doesn't static_cast work for this? If not, why not?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.