[Webkit-unassigned] [Bug 43120] [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member variable so any attempt to append strings to a WebDOMStringList instance results in a crash.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=43120





--- Comment #3 from Andrei Popescu <andreip at google.com>  2010-07-28 09:18:48 PST ---
(In reply to comment #2)
> (From update of attachment 62824 [details])
> LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js:37
>  +      shouldBe("storeNames.contains('storeName')", "true");
> Maybe also check that there's only this one item?
> 

Checked.

> WebKit/chromium/public/WebDOMStringList.h:49
>  +      WebDOMStringList();
> I'd lean towards making this private and have 2 factory methods instead: "createEmpty" and "createNull".  Though since no one needs the "null" behavior today, I'm OK with you leaving this as is.
> 

Cool, thank you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.