[Webkit-unassigned] [Bug 43120] [IndexedDB] WebDOMStringList default ctor does not initialize its m_private member variable so any attempt to append strings to a WebDOMStringList instance results in a crash.

Wed Jul 28 08:46:52 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=43120

Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62824|review?                     |review+
               Flag|                            |

--- Comment #2 from Jeremy Orlow <jorlow at chromium.org>  2010-07-28 08:46:52 PST ---
(From update of attachment 62824)
LayoutTests/storage/indexeddb/script-tests/objectstore-basics.js:37
 +      shouldBe("storeNames.contains('storeName')", "true");
Maybe also check that there's only this one item?

WebKit/chromium/public/WebDOMStringList.h:49
 +      WebDOMStringList();
I'd lean towards making this private and have 2 factory methods instead: "createEmpty" and "createNull".  Though since no one needs the "null" behavior today, I'm OK with you leaving this as is.

me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.