[Webkit-unassigned] [Bug 42834] Clients for optional features should be passed to Page constructor via structure of pointers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42834





--- Comment #17 from Steve Block <steveblock at google.com>  2010-07-28 00:30:39 PST ---
> Why not just create a PageClients structure and place all clients in there?  Some of the clients are not
> needed by Chromium, yet you have not included them in the optional set (e.g., PluginHalterClient and
> BackForwardControllerClient).
My reasoning was to use the new OptionalClients structure only for clients for optional features, ie those guarded by an ENABLE flag. In this case, the client must be non-null when the feature is enabled, otherwise it can be null. This keeps the meaning of 'optional' very clear.  If a platform does not enable the feature, it can use the default null value from the structure. 

In the case of PluginHalterClient and BackForwardControllerClient, these features are not guarded by ENABLE flags and I'm not sure of the precise conditions under which it's safe to pass a null client. Keeping them out of the optional set means that platforms must make an explicit decision to pass null, which seems safer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.