[Webkit-unassigned] [Bug 42834] Clients for optional features should be passed to Page constructor via structure of pointers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42834


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fishd at chromium.org




--- Comment #16 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-07-27 23:39:28 PST ---
(In reply to comment #2)
> This patch moves the following clients from Page constructor arguments to the 
> new OptionalClients structure.

Why not just create a PageClients structure and place all clients in there?  Some of the clients are not needed by Chromium, yet you have not included them in the optional set (e.g., PluginHalterClient and BackForwardControllerClient).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.