[Webkit-unassigned] [Bug 42304] DeviceOrientation event listeners should never be called synchronously from addEventListener()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42304





--- Comment #6 from Steve Block <steveblock at google.com>  2010-07-26 08:47:02 PST ---
> WebCore/dom/DeviceOrientationController.cpp:48
>  +      m_timer.stop();
> why is this necessary?
It's not, will remove.

> WebCore/dom/DeviceOrientationController.cpp:51
>  +              m_client->lastOrientation() : DeviceOrientation::create();
> I'd lean towards not wrapping these.
Will fix.

> WebCore/dom/DeviceOrientationController.cpp:65
>  +      // immediately trigger an asynchronous response.
I was trying to describe that the event is async, but triggered right now, without waiting for the client to get new data. Will update the comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.