[Webkit-unassigned] [Bug 42304] DeviceOrientation event listeners should never be called synchronously from addEventListener()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42304


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62390|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Jeremy Orlow <jorlow at chromium.org>  2010-07-26 08:18:13 PST ---
(From update of attachment 62390)
WebCore/dom/DeviceOrientationController.cpp:48
 +      m_timer.stop();
why is this necessary?

WebCore/dom/DeviceOrientationController.cpp:51
 +              m_client->lastOrientation() : DeviceOrientation::create();
I'd lean towards not wrapping these.

WebCore/dom/DeviceOrientationController.cpp:65
 +      // immediately trigger an asynchronous response.
This seems to imply that if it's not present, it would fire whenever it becomes so...which does't seem to be true.

Also "immediately" and "asynchronous" kind of conflict.

WebCore/dom/DeviceOrientationController.h:57
 +      typedef HashSet<DOMWindow*> ListenersSet;
I'd lean towards putting newlines between the pairs of typedef+declarations...but it's more personal preference.



r=me, but please consider making the above changes

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.