[Webkit-unassigned] [Bug 42855] Support emit_op_mod() for MIPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42855





--- Comment #3 from Chao-ying Fu <fu at mips.com>  2010-07-23 14:20:35 PST ---
(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=62358)
 --> (https://bugs.webkit.org/attachment.cgi?id=62358) [details] [details]
> > Use div for MIPS op_mod
> > 
> > The patch replaces X86Registers::eax/ecx/edx with regT0/regT2/regT1, so that MIPS can reuse source code to implement op_mod.  The MIPS build was ok, while I didn't test x86 build.  Thanks!
> 
> For X86 I'd ASSERT(regT0 == eax), etc., since the registers are implicit in the div instruction. It's important that this information is preserved, e.g. in case someone decides to change regT0 to r13 on x64. :)

Yes.  You are right.  I will update the patch to have ASSERT() for X86 and X86_64.  Thanks!

Regards,
Chao-ying

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.