[Webkit-unassigned] [Bug 42855] Support emit_op_mod() for MIPS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42855


Kent Hansen <kent.hansen at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kent.hansen at nokia.com




--- Comment #2 from Kent Hansen <kent.hansen at nokia.com>  2010-07-23 12:55:19 PST ---
(In reply to comment #1)
> Created an attachment (id=62358)
 --> (https://bugs.webkit.org/attachment.cgi?id=62358) [details]
> Use div for MIPS op_mod
> 
> The patch replaces X86Registers::eax/ecx/edx with regT0/regT2/regT1, so that MIPS can reuse source code to implement op_mod.  The MIPS build was ok, while I didn't test x86 build.  Thanks!

For X86 I'd ASSERT(regT0 == eax), etc., since the registers are implicit in the div instruction. It's important that this information is preserved, e.g. in case someone decides to change regT0 to r13 on x64. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.