[Webkit-unassigned] [Bug 41667] [Qt] QScriptEngine should have an API for creating Date objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41667


Caio Marcelo de Oliveira Filho <caio.oliveira at openbossa.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61425|0                           |1
        is obsolete|                            |
  Attachment #62146|                            |review?
               Flag|                            |




--- Comment #4 from Caio Marcelo de Oliveira Filho <caio.oliveira at openbossa.org>  2010-07-20 22:46:05 PST ---
Created an attachment (id=62146)
 --> (https://bugs.webkit.org/attachment.cgi?id=62146)
Patch v2

Thanks for the review, Jedrzej.

New version, taking into account the comments:
- QSEP::newDate code duplication removed
- Indentation/style fixed
- Tests properly generated using tools in Qt upstream

And also:
- Make use of the new QScriptOriginalGlobalObject instead of fetching/storing manually the Date constructor/prototype
- If QDateTime passed in the newDate() is not valid, return an invalid date

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.