[Webkit-unassigned] [Bug 41667] [Qt] QScriptEngine should have an API for creating Date objects
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jul 14 02:17:29 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=41667
Jędrzej Nowacki <jedrzej.nowacki at nokia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #61425|review? |
Flag| |
--- Comment #3 from Jędrzej Nowacki <jedrzej.nowacki at nokia.com> 2010-07-14 02:17:29 PST ---
(From update of attachment 61425)
Documentation is badly indented (2 instead of 4 spaces).
Could you remove code duplication? both QSEP::newDate() do the same with the same algoritm, only one difference is an argument data type.JavaScriptCore/qt/api/qscriptvalue_p.h:692
+ m_engine->setException(exception);
exception is not null, so NotNullException could be added.
JavaScriptCore/qt/tests/qscriptengine/tst_qscriptengine.cpp:560
+
Could you remove the space?
JavaScriptCore/qt/tests/qscriptengine/tst_qscriptengine.cpp:590
+ #ifndef Q_WS_WIN // TODO: Test and remove this since 169701 has been fixed
Is it still needed?
JavaScriptCore/qt/tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp:576
+ "engine->evaluate(\"Date.prototype\")",
+ "engine->newDate(QDateTime())"};
This won't work. You haven't added this values to tst_QScriptValue::initScriptValues() and to expected values for different generated functions. In the Qt repository is a generator for these files, ping me on IRC I will explain how to use it.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list