[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61783|review?                     |review+
               Flag|                            |




--- Comment #24 from chris fleizach <cfleizach at apple.com>  2010-07-16 09:49:05 PST ---
(From update of attachment 61783)
Adding r=me. I think the changes you need to make are straightforward for this one. I think calling these methods can be mostly reduce to two lines for each instance

if (AXObjectCache::)
    document()->axCache()->nodeTextChange()

WebCore/editing/AppendNodeCommand.cpp:60
 +                                                                    0, len);
indentation

WebCore/editing/AppendNodeCommand.cpp:61
 +          }
do you need the line breaking here in nodeTextChangeNotification?

WebCore/editing/AppendNodeCommand.cpp:78
 +          }
I think the len > 0, node->nodeValue() != "\n" should go into the logic inside AXObjectCache. Different platforms may want to process those, so i think it should be left up to AX code to handle those cases.
it will also make these code snippets much simpler

WebCore/editing/DeleteFromTextNodeCommand.cpp:63
 +  
for one line if statements, no braces needed

WebCore/editing/DeleteFromTextNodeCommand.cpp:82
 +  }
no braces needed

WebCore/editing/InsertIntoTextNodeCommand.cpp:57
 +      }
no braces needed

WebCore/editing/InsertIntoTextNodeCommand.cpp:71
 +  
no braces needed

WebCore/editing/InsertNodeBeforeCommand.cpp:62
 +          }
same comments, let the AX code handle whether it should process this based on length or not

WebCore/editing/InsertNodeBeforeCommand.cpp:78
 +          }
ditto as above

WebCore/editing/InsertNodeBeforeCommand.cpp:84
 +  1.7.0.4
extra line removed, should not be

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.