[Webkit-unassigned] [Bug 25898] [Gtk] object:text-changed events should be emitted for entries and password text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=25898


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61782|review?                     |review-
               Flag|                            |




--- Comment #23 from chris fleizach <cfleizach at apple.com>  2010-07-16 09:43:32 PST ---
(From update of attachment 61782)
This patch is just about there. I'm putting review- just because i'd like to see it one more time before it goes through. thanks!

WebCore/accessibility/AXObjectCache.cpp:473
 +  }
it looks like you don't really need this method, since its only used by the RenderObject version.

WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:68
 +  
This looks like a roundabout way to get object->parentObject()->wrapper(). 

WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:73
 +  
identation is wrong

WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:88
 +  
identation is wrong

WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:94
 +  }
looks like you should use a switch statement here which sets a char* or String to "text-change*". then you'd only have to call g_signal* one time.

WebCore/accessibility/win/AXObjectCacheWin.cpp:113
 +  1.7.0.4
extra line removal not needed

WebCore/accessibility/gtk/AXObjectCacheAtk.cpp:65
 +  
identation

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.