[Webkit-unassigned] [Bug 41441] Add a target URL parameter to the createView and createWindow method

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=41441





--- Comment #20 from Johnny Ding <jnd at chromium.org>  2010-07-15 07:26:25 PST ---
> 
> OK, I see that explained in a FIXME comment in the code.
> 
> This seems pretty unfortunate.  I think the objective of that comment is to
> prevent an embedder from loading the given FrameLoadRequest inside the
> createWindow call.  However, by plumbing the URL through the createWindow
> call as your patch is doing, you are effectively making it possible for
> the embedder to load the URL straight away.
> 
> It seems like we should fix all of the embedders to not load the request
> inside of createWindow, and then we should be able to safely pass the
> target URL as the URL of the FrameLoadRequest.
> 
> Plumbing another URL parameter alongside the FrameLoadRequest doesn't seem
> like the right solution to me.

I see, you are right, this additional targetURL parameter looks redundant.
I will investigate how many code will be affected if we pass target URL as the URL of the FrameLoadRequest and come up with a new patch.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.