[Webkit-unassigned] [Bug 41441] Add a target URL parameter to the createView and createWindow method

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 14 09:28:13 PDT 2010


--- Comment #19 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-07-14 09:28:13 PST ---
(In reply to comment #14)
> Yes, ideally the targetURL should be as same as the URL in the frameRequest, 
> but according to the comments in JSDOMWindowCustom.cpp, now  the code only 
> passes the empty string for the URL. The reason is,  before loading the URL, we 
> have to set up the opener, openedByDOM, and dialogArguments values. Also, to 
> decide whether to use the URL we currently do an allowsAccessFrom call using 
> the window we create, which can't be done before creating it. We'd have to 
> resolve all those issues to pass the URL instead of "".

OK, I see that explained in a FIXME comment in the code.

This seems pretty unfortunate.  I think the objective of that comment is to
prevent an embedder from loading the given FrameLoadRequest inside the
createWindow call.  However, by plumbing the URL through the createWindow
call as your patch is doing, you are effectively making it possible for
the embedder to load the URL straight away.

It seems like we should fix all of the embedders to not load the request
inside of createWindow, and then we should be able to safely pass the
target URL as the URL of the FrameLoadRequest.

Plumbing another URL parameter alongside the FrameLoadRequest doesn't seem
like the right solution to me.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list