[Webkit-unassigned] [Bug 42161] Removes cycles caused by "m_this" members in a few IndexedDB classes.

Tue Jul 13 07:40:53 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=42161

Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #61371|review?                     |review-
               Flag|                            |

--- Comment #6 from Jeremy Orlow <jorlow at chromium.org>  2010-07-13 07:40:54 PST ---
(From update of attachment 61371)
WebCore/storage/IDBAny.h:47
 +      // Only valid with T accepted by set().
I'd lean towards leaving this comment out.  I think it's pretty clear from the code.

WebCore/storage/IDBAny.h:49
 +      static PassRefPtr<IDBAny> create(PassRefPtr<T> idbObject)
I think it'd be slightly cleaner if you took in a raw pointer and created the passRefPtr in this method.  That way we don't have all the redundant data scattered through the rest of the file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.