[Webkit-unassigned] [Bug 42161] Removes cycles caused by "m_this" members in a few IndexedDB classes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42161





--- Comment #5 from Marcus Bulach <bulach at chromium.org>  2010-07-13 07:28:09 PST ---
(In reply to comment #3)
> (From update of attachment 61364 [details])
> WebCore/storage/IDBAny.h:46
>  +      static PassRefPtr<IDBAny> create();
> Do we still need this?
yep, http://trac.webkit.org/browser/trunk/WebCore/storage/IDBRequest.cpp still uses it..

> 
> WebCore/storage/IDBAny.cpp:40
>  +  static PassRefPtr<IDBAny> createIDBAny(PassRefPtr<T> idbType)
> Hm...it seems like you could have just added the template function to the IDBAny.h if you wanted...right?

indeed, done. note though that due to the automatic type conversion from Foo* to PassRefPtr<Foo>, the caller needs to specify the type on the templated call site.

another look please?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.