[Webkit-unassigned] [Bug 40932] Separate line-ending conversion code from BlobItem for code cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 9 18:52:45 PDT 2010


--- Comment #4 from Kinuko Yasuda <kinuko at chromium.org>  2010-07-09 18:52:45 PST ---
Thanks for reviewing, updated the code with recent fixes.

(In reply to comment #2)
> (From update of attachment 59273 [details])
> WebCore/platform/text/LineEnding.cpp:2
>  +   * Copyright (C) 2010 Google Inc. All rights reserved.
> Please check the author of the original function and give credit here too.


> WebCore/platform/text/LineEnding.h:53
>  +  // Convert WebCore::String to CString with given line-ending and encoding.
> This comment is a little bit vague. It does not mention what is fixed regarding the line ending. Could you please add more detailed comment here?
> Also mentioning "Convert WebCore::String to CString" seems to be unnecessary since the argument type and return type indicate that clearly.

Fixed - also splitted the function into simple ones (one for converting CRLF, one for CR, one for LF and etc).

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list